Don't apply screen flash to players with repeating flashes - #70
Closed
tsdko wants to merge 1 commit into
Closed
Conversation
This replicates the pre-9c203419af behavior where screen flashes (Scene_Map::UpdateStage1 → Game_Map::Update → Game_Screen::Update → … → Game_Screen::FlashOnce) would immediately get overwritten by repeating flashes (Scene_Map::UpdateStage1 → Scene_Map::UpdateGraphics → Spriteset_Map::Update). Fixes PlayerOther flickering in MAP2059 (Sunset Savannah, Yume 2kki) seen during the event triggered by using the Fairy effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replicates the pre- 9c20341 behavior where screen flashes
(
Scene_Map::UpdateStage1 → Game_Map::Update → Game_Screen::Update → … → Game_Screen::FlashOnce)would immediately get overwritten by repeating flashes
(
Scene_Map::UpdateStage1 → Scene_Map::UpdateGraphics → Spriteset_Map::Update).Fixes PlayerOther flickering in MAP2059 (Sunset Savannah, Yume 2kki) seen during the event triggered by using the Fairy effect.
(save file before triggering the event)
More context: battle animations (such as the one in the event above) trigger a 0-frame screen flash on each frame. This doesn't actually cause the screen to flash but does cancel out any existing screen flash if there's one active.